-
Notifications
You must be signed in to change notification settings - Fork 44
Revert "Let generic-worker verify run-task/fetch-content integrity" #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 500a944.
…askcluster#666)" This causes failures because not all tasks have a direct dependency on the decision task, but generic-worker insists on that dependency existing when mounting an artifact from a task. So go back to mounting by url. This reverts commit f85ff32.
Eijebong
reviewed
May 13, 2025
Eijebong
approved these changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to click approve, don't have super strong feelings about keeping those
bhearsum
added a commit
to bhearsum/translations
that referenced
this pull request
May 14, 2025
This picks up taskcluster/taskgraph#691, which is needed to revert back to the old GPU worker image.
bhearsum
added a commit
to bhearsum/translations
that referenced
this pull request
May 15, 2025
This picks up taskcluster/taskgraph#691, which is needed to revert back to the old GPU worker image.
bhearsum
added a commit
to bhearsum/translations
that referenced
this pull request
May 15, 2025
This picks up taskcluster/taskgraph#691, which is needed to revert back to the old GPU worker image.
eu9ene
pushed a commit
to mozilla/translations
that referenced
this pull request
May 15, 2025
* backout switching gpu workers to docker + new worker image * upgrade to taskgraph 14.2.1 This picks up taskcluster/taskgraph#691, which is needed to revert back to the old GPU worker image.
gregtatum
pushed a commit
to mozilla/translations
that referenced
this pull request
May 16, 2025
This picks up taskcluster/taskgraph#691, which is needed to revert back to the old GPU worker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of the initial issue with the task schema not getting updated to match, it also causes failures because not all tasks have a direct dependency on the decision task, but generic-worker insists on that dependency existing when mounting an artifact from a task. So go back to mounting by url.